Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required attribute to file input field #2846

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Aug 26, 2024

Fixes #2177

Changes Proposed in this Pull Request

  • Make sure the required attribute is added to the file input when appropriate, similar to the rest of the field types

Testing Instructions

*See #2177 to test it with the Applications add-on

Release Notes

  • Fix file input field for forms not marked as required

Screenshot / Video


Plugin build for 4bd7a24
📦 Download plugin zip
▶️ Open in playground

@yscik yscik requested a review from a team August 26, 2024 08:13
@yscik yscik self-assigned this Aug 26, 2024
Copy link
Contributor

@pgk pgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as described!

Screenshot 2024-08-27 at 2 07 55 PM

@yscik yscik merged commit f89a227 into trunk Aug 27, 2024
12 checks passed
@yscik yscik deleted the add/file-field-required branch August 27, 2024 18:22
@yscik yscik added this to the 2.4.1 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application addon required file validation
2 participants